Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add MCX N94x multidrv #508

Merged
merged 1 commit into from
Aug 2, 2024
Merged

Add MCX N94x multidrv #508

merged 1 commit into from
Aug 2, 2024

Conversation

agkaminski
Copy link
Member

@agkaminski agkaminski commented Jul 26, 2024 •
edited
Loading

JIRA: RTOS-881

Description

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (refactoring, style fixes, git/CI config, submodule management, no code logic changes)

How Has This Been Tested?

  • Already covered by automatic testing.
  • New test added: (add PR link here).
  • Tested by hand on: (mcxn94x).

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

github-actions[bot]
github-actions bot reviewed Jul 26, 2024
View reviewed changes
multi/mcxn94x-multi/common.h Show resolved Hide resolved
multi/mcxn94x-multi/common.h Show resolved Hide resolved
multi/mcxn94x-multi/common.h Show resolved Hide resolved
multi/mcxn94x-multi/mcxn94x-multi.c Outdated Show resolved Hide resolved
multi/mcxn94x-multi/uart.c Show resolved Hide resolved
multi/mcxn94x-multi/uart.c Outdated Show resolved Hide resolved
multi/mcxn94x-multi/uart.c Show resolved Hide resolved
multi/mcxn94x-multi/uart.c Outdated Show resolved Hide resolved
multi/mcxn94x-multi/uart.c Outdated Show resolved Hide resolved
github-actions[bot]
github-actions bot reviewed Jul 26, 2024
View reviewed changes
multi/mcxn94x-multi/uart.c Outdated Show resolved Hide resolved
multi/mcxn94x-multi/uart.c Outdated Show resolved Hide resolved
This was referenced Jul 26, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 26, 2024 •
edited
Loading

Unit Test Results

6 780 tests   - 920   6 154 ✅  - 831   31m 50s ⏱️ - 6m 1s
  380 suites  -  56     626 💤  -  89 
    1 files   ±  0       0 ❌ ±  0 

Results for commit 1725d30. ± Comparison against base commit 4d8edcc.

This pull request removes 920 tests. 
flash ‑ armv7a9-zynq7000-zedboard:flash
phoenix-rtos-tests/cpp/hello-cpp ‑ armv7a9-zynq7000-zedboard:phoenix-rtos-tests/cpp/hello-cpp
phoenix-rtos-tests/initfini/main ‑ armv7a9-zynq7000-zedboard:phoenix-rtos-tests/initfini/main
phoenix-rtos-tests/ioctl/unit ‑ armv7a9-zynq7000-zedboard:phoenix-rtos-tests/ioctl/unit.ioctl.data_in
phoenix-rtos-tests/ioctl/unit ‑ armv7a9-zynq7000-zedboard:phoenix-rtos-tests/ioctl/unit.ioctl.data_in_big
phoenix-rtos-tests/ioctl/unit ‑ armv7a9-zynq7000-zedboard:phoenix-rtos-tests/ioctl/unit.ioctl.data_inout
phoenix-rtos-tests/ioctl/unit ‑ armv7a9-zynq7000-zedboard:phoenix-rtos-tests/ioctl/unit.ioctl.data_inout_big
phoenix-rtos-tests/ioctl/unit ‑ armv7a9-zynq7000-zedboard:phoenix-rtos-tests/ioctl/unit.ioctl.data_out
phoenix-rtos-tests/ioctl/unit ‑ armv7a9-zynq7000-zedboard:phoenix-rtos-tests/ioctl/unit.ioctl.data_out_big
phoenix-rtos-tests/ioctl/unit ‑ armv7a9-zynq7000-zedboard:phoenix-rtos-tests/ioctl/unit.ioctl.in_val
…

♻️ This comment has been updated with latest results.

lukileczo
lukileczo reviewed Jul 29, 2024
View reviewed changes
_targets/Makefile.armv8m33-mcxn94x Outdated Show resolved Hide resolved
multi/mcxn94x-multi/dummyfs.c Outdated Show resolved Hide resolved
multi/mcxn94x-multi/dummyfs.c Outdated Show resolved Hide resolved
multi/mcxn94x-multi/mcxn94x-multi.h Outdated Show resolved Hide resolved
multi/mcxn94x-multi/uart.c Outdated Show resolved Hide resolved
multi/mcxn94x-multi/uart.c Outdated Show resolved Hide resolved
multi/mcxn94x-multi/uart.c Outdated Show resolved Hide resolved
multi/mcxn94x-multi/uart.c Outdated Show resolved Hide resolved
multi/mcxn94x-multi/uart.c Outdated Show resolved Hide resolved
multi/mcxn94x-multi/uart.c Outdated Show resolved Hide resolved
lukileczo
lukileczo approved these changes Aug 1, 2024
View reviewed changes
Copy link
Member

@lukileczo lukileczo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agkaminski
Add MCX N94x multidrv
1725d30 
JIRA: RTOS-881
@agkaminski agkaminski merged commit 3d18d6b into master Aug 2, 2024
28 of 30 checks passed
@agkaminski agkaminski deleted the agkaminski/n94x branch August 2, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions GitHub Actions GitHub Actions left review comments

@lukileczo lukileczo lukileczo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@agkaminski @lukileczo